From 8a111bf964b4283bfbdb3070d024370e2835a592 Mon Sep 17 00:00:00 2001 From: "Gustavo A. R. Silva" Date: Wed, 16 Feb 2022 13:49:55 -0600 Subject: [PATCH] carl9170: Replace zero-length arrays with flexible-array members MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit There is a regular need in the kernel to provide a way to declare having a dynamically sized set of trailing elements in a structure. Kernel code should always use “flexible array members”[1] for these cases. The older style of one-element or zero-length arrays should no longer be used[2]. [1] https://en.wikipedia.org/wiki/Flexible_array_member [2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays Link: https://github.com/KSPP/linux/issues/78 Signed-off-by: Gustavo A. R. Silva Signed-off-by: Christian Lamparter --- include/shared/fwdesc.h | 2 +- include/shared/wlan.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/shared/fwdesc.h b/include/shared/fwdesc.h index 503b21a..10acb6a 100644 --- a/include/shared/fwdesc.h +++ b/include/shared/fwdesc.h @@ -149,7 +149,7 @@ struct carl9170fw_fix_entry { struct carl9170fw_fix_desc { struct carl9170fw_desc_head head; - struct carl9170fw_fix_entry data[0]; + struct carl9170fw_fix_entry data[]; } __packed; #define CARL9170FW_FIX_DESC_SIZE \ (sizeof(struct carl9170fw_fix_desc)) diff --git a/include/shared/wlan.h b/include/shared/wlan.h index 61c3112..78b0ee4 100644 --- a/include/shared/wlan.h +++ b/include/shared/wlan.h @@ -327,7 +327,7 @@ struct _carl9170_tx_superdesc { struct _carl9170_tx_superframe { struct _carl9170_tx_superdesc s; struct _ar9170_tx_hwdesc f; - u8 frame_data[0]; + u8 frame_data[]; } __packed __aligned(4); #define CARL9170_TX_SUPERDESC_LEN 24 -- 2.31.1